Narrow table panes panic in `get_percentage_width` (u16 underflow)

[LargeModGames]

What

get_percentage_width subtracts a 3-column padding from a u16 with plain -, so a table pane narrower than 3 columns panics in debug builds (attempt to subtract with overflow) and silently wraps in release builds. I hit it by opening a track table and pressing } until the sidebar fills the screen. I'd also like tests for this function and its neighbor truncate_text, which has none.

Where to look

• get_percentage_width, truncate_text and the mod tests at the bottom of src/tui/ui/util.rs

Possible solution

• The fix is one call: width.saturating_sub(padding).
• Write the failing test first: get_percentage_width(2, 0.5) panics under cargo test today.
• Good cases: widths 0 to 3 give 0, (103, 0.5) gives 50, and truncate_text("abcdef", 4) gives "abc…" (one … char, not three dots). For "héllo wörld" with max 5, check .chars().count(), not .len().
• Name tests as behavior sentences with no test_ prefix or _test suffix (the two existing tests predate that rule).
• Each new #[test] raises test_attribute_total in tools/gates.count by one. If the number is off, cargo test fails in src/gates.rs and prints the right one.

Done when

• New tests for both functions pass.
• cargo fmt --all -- --check, cargo clippy --no-default-features --features telemetry,tui -- -D warnings and cargo test --no-default-features --features telemetry,tui pass.

[spotatui]

🎧 spotatui triage

Auto-triaged with DeepSeek V4-Flash.

Label: bug
Likely area: TUI table pane width calculation (src/tui/ui/util.rs)

Summary

get_percentage_width performs a plain u16 subtraction of a 3-column padding, so any table pane narrower than 3 columns underflows. In debug builds this panics with 'attempt to subtract with overflow'; in release builds it silently wraps, producing incorrect widths. The reporter triggered it by opening a track table and pressing } until the sidebar filled the screen. The issue also requests adding unit tests for get_percentage_width and truncate_text, which currently have none.

Key points

• get_percentage_width subtracts a 3-column padding from a u16 using plain -
• Panes narrower than 3 columns panic in debug builds ('attempt to subtract with overflow') and silently wrap in release builds
• Reproduced by opening a track table and pressing } until the sidebar fills the screen
• Proposed fix: width.saturating_sub(padding)
• Requests tests for both get_percentage_width and truncate_text (currently untested)

What would help

• OS and terminal
• spotatui version
• Exact expected vs actual widths for the affected layout

Possible duplicates: none found

_{Compared against the 29 most recently updated open issues.}