fix: handle embedded cubemap face order correctly - #996
Open
michaeloliverx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may not be worth the churn, but I’m opening it to make the behaviour visible and invite discussion.
I found this while working in a fork that consumes embedded cubemap data directly in memory, before it is written back out. It took me a while to identify the cause. 😅
Embedded cubemap data is face-major, but OAT currently interprets it as mip-major. The DDS writer also emitted cubemaps mip-major, so the two mistakes effectively cancelled each other out? dumped DDS files looked correct despite the in-memory face assignment being wrong.
This probably applies to other games as well, but I have only opted in IW3 here as a verified example rather than assuming the same embedded layout everywhere.