Repository navigation
Conversation
Write uncaught exceptions to stderr with real newlines, including the previous-exception chain. Escape control characters to prevent log forging, use colors only on a TTY, fall back to error_log() and never throw from the handler. Assisted-by: Claude:claude-sonnet-5-5
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The global exception handler now writes uncaught exceptions to stderr
with real newlines instead of a single escaped line.
error_log()if stderr is unavailableTesting
tests/lib/Common/Logging/ExceptionHandlerTest.php(chain, escaping, TTY/no-TTY, fallback, no-throw)
🤖 Generated with Claude Code