Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions packages/api/src/agents/__tests__/initialize.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,8 @@ describe('initializeAgent — stable and dynamic instruction fields', () => {
);

expect(result.instructions).toBeUndefined();
expect(result.additional_instructions).toBe(
expect(result.additional_instructions).toBeUndefined();
expect(result.dynamicToolContextMap?.agent_temporal_instructions).toBe(
'Today is 2026-08-31 (Monday). The turn began at 2026-08-31 06:20:00 +00:00 (Monday) (2026-08-31T06:20:00.000Z).',
);
});
Expand All @@ -1383,11 +1384,56 @@ describe('initializeAgent — stable and dynamic instruction fields', () => {
);

expect(result.instructions).toBeUndefined();
expect(result.additional_instructions).toBe(
expect(result.additional_instructions).toBeUndefined();
expect(result.dynamicToolContextMap?.agent_temporal_instructions).toBe(
'It is currently 2024-01-15 13:30:00 -05:00 (Monday).',
);
});

it('keeps artifact guidance before all per-turn context without mutating shared tool context', async () => {
const { generateArtifactsPrompt } = jest.requireMock('~/prompts') as {
generateArtifactsPrompt: jest.Mock;
};
generateArtifactsPrompt.mockReturnValue('Artifact guidance');

const { agent, req, res, loadTools, db } = createMocks();
const webContext = { web_search: 'Conversation Date & Time: 2026-08-31T06:20:00.000Z' };
loadTools.mockResolvedValueOnce({
tools: [],
toolContextMap: {},
dynamicToolContextMap: webContext,
toolDefinitions: [],
hasDeferredTools: false,
});
agent.additional_instructions = 'Stable agent context';
agent.instructions = 'Today is {{current_date}}.';
agent.artifacts = 'enabled' as never;
req.turnStartedAt = new Date('2026-08-31T06:20:00.000Z').getTime();
req.body = { timezone: 'UTC' };

const result = await initializeAgent(
{
req,
res,
agent,
loadTools,
endpointOption: { endpoint: EModelEndpoint.agents },
allowedProviders: new Set([Providers.OPENAI]),
isInitialAgent: true,
},
db,
);

expect(result.additional_instructions).toBe('Stable agent context\n\nArtifact guidance');
expect(result.dynamicToolContextMap).toEqual({
...webContext,
agent_temporal_instructions: 'Today is 2026-08-31 (Monday).',
});
expect(webContext).toEqual({
web_search: 'Conversation Date & Time: 2026-08-31T06:20:00.000Z',
});
});

it('keeps non-temporal special vars in stable instructions', async () => {
const { agent, req, res, loadTools, db } = createMocks();
agent.instructions = 'You are helping {{current_user}}.';
Expand Down
28 changes: 26 additions & 2 deletions packages/api/src/agents/__tests__/run-summarization.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2086,7 +2086,29 @@ describe('stable/dynamic system instructions', () => {
});

expect(agents[0].instructions).toBe('Static tool instructions\nBase instructions');
expect(agents[0].additional_instructions).toBe('Conversation Date & Time: anchor\nMemory tail');
expect(agents[0].additional_instructions).toBe('Memory tail\nConversation Date & Time: anchor');
});

it('preserves the full artifact prefix when timestamps change between turns', async () => {
const agents = await callAndCapture({
agents: ['2026-08-31T06:20:00.000Z', '2026-08-31T06:21:00.000Z'].map((time, index) =>
makeAgent({
id: `agent_${index}`,
instructions: 'Stable agent instructions',
additional_instructions: 'Artifact guidance',
toolContextMap: { web_search: 'Static web instructions' },
dynamicToolContextMap: { web_search: `Conversation Date & Time: ${time}` },
}),
),
});

expect(agents[0].instructions).toBe(agents[1].instructions);
expect(agents[0].additional_instructions).toBe(
'Artifact guidance\nConversation Date & Time: 2026-08-31T06:20:00.000Z',
);
expect(agents[1].additional_instructions).toBe(
'Artifact guidance\nConversation Date & Time: 2026-08-31T06:21:00.000Z',
);
});
});

Expand Down Expand Up @@ -3192,6 +3214,7 @@ describe('subagentConfigs', () => {
const member = makeAgent({
id: 'agent_skilled_member',
additional_instructions: 'Keep the response concise.',
dynamicToolContextMap: { web_search: 'Conversation Date & Time: anchor' },
alwaysApplySkillPrimes: [
{ name: 'member-workflow', body: 'Follow the member-specific workflow.' },
],
Expand All @@ -3218,7 +3241,8 @@ describe('subagentConfigs', () => {
const [memberInput] = config.agents as Array<Record<string, unknown>>;
expect(memberInput.additional_instructions).toBe(
'Keep the response concise.\n\n' +
'# Always-apply skill: member-workflow\nFollow the member-specific workflow.',
'# Always-apply skill: member-workflow\nFollow the member-specific workflow.\n' +
'Conversation Date & Time: anchor',
);
});

Expand Down
7 changes: 5 additions & 2 deletions packages/api/src/agents/initialize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2251,6 +2251,7 @@ export async function initializeAgent(
(agent.model_parameters as Record<string, unknown>).configuration = options.configOptions;
}

let temporalInstructions: string | undefined;
if (agent.instructions && agent.instructions !== '') {
const resolvedInstructions = replaceSpecialVars({
text: agent.instructions,
Expand All @@ -2260,7 +2261,7 @@ export async function initializeAgent(
});
if (hasTemporalSpecialVars(agent.instructions)) {
agent.instructions = undefined;
appendAdditionalInstructions(agent, resolvedInstructions);
temporalInstructions = resolvedInstructions;
} else {
agent.instructions = resolvedInstructions;
}
Expand Down Expand Up @@ -2524,7 +2525,9 @@ export async function initializeAgent(
agentContextAttachments,
fileConsumers,
toolContextMap: toolContextMap ?? {},
dynamicToolContextMap: dynamicToolContextMap ?? {},
dynamicToolContextMap: temporalInstructions
? { ...dynamicToolContextMap, agent_temporal_instructions: temporalInstructions }
: (dynamicToolContextMap ?? {}),
useLegacyContent: !!options.useLegacyContent,
tools: (tools ?? []) as GenericTool[] & string[],
maxToolResultChars: maxToolResultCharsResolved,
Expand Down
26 changes: 26 additions & 0 deletions packages/api/src/agents/run.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
shouldReplayReasoningContent,
anyAgentReplaysReasoningContent,
collectRunMCPToolAliases,
buildAdditionalInstructions,
} from './run';

describe('getRunDiscoveredTools', () => {
Expand Down Expand Up @@ -471,3 +472,28 @@ describe('collectRunMCPToolAliases', () => {
expect(collectRunMCPToolAliases([root] as never)).toEqual([graphAlias]);
});
});

describe('buildAdditionalInstructions', () => {
it('places dynamic tool context after static additional instructions', () => {
const result = buildAdditionalInstructions(
'Artifacts prompt',
'Conversation Date & Time: 2025-01-01T00:00:00.000Z',
);

expect(result).toBe('Artifacts prompt\nConversation Date & Time: 2025-01-01T00:00:00.000Z');
});

it('keeps the static prefix identical when only the dynamic context changes', () => {
const first = buildAdditionalInstructions('Artifacts prompt', 'Time: 1');
const second = buildAdditionalInstructions('Artifacts prompt', 'Time: 2');

expect(first.startsWith('Artifacts prompt\n')).toBe(true);
expect(second.startsWith('Artifacts prompt\n')).toBe(true);
});

it('handles missing additional instructions and empty dynamic context', () => {
expect(buildAdditionalInstructions(undefined, 'Time: 1')).toBe('Time: 1');
expect(buildAdditionalInstructions('Artifacts prompt', '')).toBe('Artifacts prompt');
expect(buildAdditionalInstructions(undefined, '')).toBe('');
});
});
40 changes: 28 additions & 12 deletions packages/api/src/agents/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,18 @@ export interface RunDiscoverySnapshot {
getRunMessages?: () => BaseMessage[] | undefined;
}

/**
* Joins additional instructions with per-request tool context. The dynamic part
* (e.g. the current date/time) goes last so that provider-side prefix caches
* can reuse the static part, such as the artifacts prompt, across requests.
*/
export function buildAdditionalInstructions(
additionalInstructions: string | null | undefined,
dynamicToolInstructions: string,
): string {
return [additionalInstructions ?? '', dynamicToolInstructions].join('\n').trim();
}

/** Reads canonical run discovery state, with best-effort history parsing for older releases. */
export function getRunDiscoveredTools(run: RunDiscoverySnapshot): string[] {
if (typeof run.getDiscoveredTools === 'function') {
Expand Down Expand Up @@ -1830,16 +1842,19 @@ function buildIsolatedAgentInputs(
child: RunAgent,
toInput: (agent: RunAgent, opts?: { isSubagent?: boolean }) => AgentInputs,
): AgentInputs {
const childInputs = toInput(child, { isSubagent: true });
const alwaysApplySkillPrimes = child.alwaysApplySkillPrimes;
if (alwaysApplySkillPrimes && alwaysApplySkillPrimes.length > 0) {
const skillInstructions = alwaysApplySkillPrimes
.map((prime) => `# Always-apply skill: ${prime.name}\n${prime.body}`)
.join('\n\n');
childInputs.additional_instructions = [childInputs.additional_instructions, skillInstructions]
.filter((value): value is string => typeof value === 'string' && value.length > 0)
.join('\n\n');
}
const skillInstructions = alwaysApplySkillPrimes
?.map((prime) => `# Always-apply skill: ${prime.name}\n${prime.body}`)
.join('\n\n');
const childWithSkill = skillInstructions
? {
...child,
additional_instructions: [child.additional_instructions, skillInstructions]
.filter((value): value is string => typeof value === 'string' && value.length > 0)
.join('\n\n'),
}
: child;
const childInputs = toInput(childWithSkill, { isSubagent: true });
if ((child.backgroundToolNames?.length ?? 0) > 0) {
childInputs.toolDefinitions = stripBackgroundFromToolDefinitions(
childInputs.toolDefinitions,
Expand Down Expand Up @@ -2412,9 +2427,10 @@ export async function createRun({

const systemContent = [toolInstructions, agent.instructions ?? ''].join('\n').trim();

const additionalInstructions = [dynamicToolInstructions, agent.additional_instructions ?? '']
.join('\n')
.trim();
const additionalInstructions = buildAdditionalInstructions(
agent.additional_instructions,
dynamicToolInstructions,
);

/** Resolves issues with new OpenAI usage field */
if (
Expand Down
Loading