Skip to content

🛑 fix: Stop Agent On Aborted Tool Calls - #566

Merged
danny-avila merged 1 commit into
mainfrom
lia/stop-on-abort-tool-errors
Sep 25, 2026
Merged

danny-avila merged 1 commit into
mainfrom
lia/stop-on-abort-tool-errors

Conversation

@lia-by-librechat

Copy link
Copy Markdown
Contributor

Summary

  • Replace the retry-oriented tool error text with an explicit stop-and-wait instruction when LibreChat reports an abort on a cancelled run.
  • Keep ordinary failures (including unrelated failures racing a stop) unchanged, and avoid classifying stream-limit or prepared-subagent safety aborts as user stops.
  • Apply the same formatting to direct tools, event results, early completions and eager stream completions so model-visible content and step events agree.
  • Avoid claiming an in-flight tool had no side effects: its effects must not be assumed.

Checks

  • jest --runInBand --coverage=false --silent src/tools/__tests__/toolErrorContent.test.ts src/tools/__tests__/ToolNode.breakerSignal.test.ts src/tools/__tests__/ToolNode.onResultCompletion.test.ts src/__tests__/stream.eagerEventExecution.test.ts (104 passed)
  • tsc --noEmit (passed)
  • eslint on the 7 changed TypeScript files (passed)
  • git diff --check (passed)

@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T12:03:29.950553Z abc3ce3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: abc3ce3876

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 5fb3238 into main Sep 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants