feat: setup check implementation

[guilhermercarvalho]

Related Issue

Issue Number: #6590

Pull Request Type

• Feature
• Refactoring

Pull request checklist

• Did you explain or provide a way of how can we test your code ?
• If your pull request is related to frontend modifications provide a print of before and after screen
• Did you provide a general summary of your changes ?
• Try to limit your pull request to one type, submit multiple pull requests if needed
• I implemented tests that cover my contribution

Summary of Changes

This PR replaces the custom ConfigureCheckService with a set of specialized classes implementing Nextcloud's native ISetupCheck interface. This improves maintainability, reuses core APIs, and makes the checks visible in the admin overview and available via occ setupchecks:check.

The following checks were created, preserving all original logic from ConfigureCheckService:

Check Name	Priority	Category	Source Method
JavaSetupCheck	must-have	system	ConfigureCheckService::checkJava()
JSignPdfSetupCheck	must-have	system	ConfigureCheckService::checkJSignPdf()
PDFtkSetupCheck	must-have	system	ConfigureCheckService::checkPdftk()
CertificateEngineSetupCheck	must-have	security	ConfigureCheckService::checkCertificate()
PopplerSetupCheck	nice-to-have	system	ConfigureCheckService::checkPoppler()
ImagickSetupCheck	nice-to-have	system	ConfigureCheckService::checkImagick()

All checks are registered in Application.php. The old ConfigureCheckService has been removed (not just deprecated) as it is fully replaced by the new implementation.

Key Changes

• Command occ libresign:configure:check now uses SetupCheckResultService to aggregate results, preserving the existing --sign (system category) and --certificate (security category) filters.
• AdminController endpoints and SSE events now use the new service, removing the need for manual cache clearing (disableCache() is gone).
• Certificate engine handler (AEngineHandler.php): the filterNameValue method now returns OU values as a comma-separated string instead of an array. This change was made to align with the new setup check structure and to fix a failing test in AdminControllerTest. Note: I'm not entirely sure about the full impact of this change on certificate generation; a careful review of this part is highly appreciated.
• Tests were completely rewritten to mock exec() and file_exists() inside the SetupCheck namespace, ensuring reliable unit testing without affecting global functions.

Screenshots

How to Test

1. Via web interface

   • Navigate to Administration settings → Overview.
   • Scroll to the "Setup checks" section.
   • Verify that all six LibreSign checks are present in the list (Java, JSignPdf, PDFtk, Poppler, Imagick, CertificateEngine).
   • Their statuses will reflect your actual system configuration:
     • Poppler and Imagick should show success if installed (or info if missing).
     • CertificateEngine will likely show error until configured (e.g., openssl engine not set up).
   • This confirms the checks are properly registered and executing.

2. Via CLI

   occ setupchecks:check

   The output should include all LibreSign checks (Java, JSignPdf, PDFtk, Poppler, Imagick, CertificateEngine).

3. Run unit tests

   composer test:unit -- --filter SetupCheck

   All tests should pass.

Before / After CLI Output

Before (using occ libresign:configure:check):

...
success   java                Java version: openjdk version "21.0.8" 2025-07-15 LTS
success   java                Java binary: /path/to/java
success   pdftk               PDFtk version: 3.3.3
success   pdftk               PDFtk path: /path/to/pdftk.jar
...
error    openssl-configure   OpenSSL (root certificate) not configured.

After (same command, now using new checks):

...
success   Java                Java version: openjdk version "21.0.8" 2025-07-15 LTS
                             Java binary: /path/to/java
success   JSignPdf            JSignPdf version: 2.3.0
                             JSignPdf path: /path/to/jsignpdf.jar
success   PDFtk               PDFtk version: 3.3.3
                             PDFtk path: /path/to/pdftk.jar
success   Poppler             pdfsig version: 25.03.0, pdfinfo version: 25.03.0
success   Imagick             Imagick extension is loaded
error    CertificateEngine   [ERROR] OpenSSL (root certificate) not configured.

Additional Notes for Reviewers

• Backward compatibility: The legacy API endpoint /api/v1/admin/configure-check now returns data via SetupCheckResultService::getLegacyFormattedChecks(), ensuring no breakage for existing frontend code.
• Cache handling: The removed disableCache() method was only used during SSE updates; the new implementation calls the setup check manager directly, which already handles caching appropriately.
• Category mapping: --sign shows checks with category system, --certificate shows security. This matches the original intent and is clearly documented.
• Testing approach: Global functions exec and file_exists are mocked by redefining them in the OCA\Libresign\SetupCheck namespace only during tests – a safe and isolated method.
• OU formatting change: The modification in AEngineHandler (returning a string instead of an array for OrganizationalUnit) was necessary to pass tests but may have unforeseen consequences. Please review this part carefully, especially regarding certificate generation and compatibility with different certificate engines.

[vitormattos]

Run the command at LibreSign folder inside container:
composer cs:fix
Some files have a wrong indent pattern.

[guilhermercarvalho]

Thanks for the feedback! I'm working on the suggestions and will update the PR soon.

[vitormattos]

This is a partial review. I need to conduct a more thorough check soon.

[YvesCesar]

@vitormattos

I've solve the new revisions.

[vitormattos]

/backport to stable34

[vitormattos]

/backport to stable33

[vitormattos]

/backport to stable32