Repository navigation
Support numeric fileSize in FullscreenImageCarousel - #1500
Merged
Merged
Conversation
ghazwan-gt
previously approved these changes
Oct 6, 2026
ziggyzet
previously approved these changes
Oct 6, 2026
qroll
marked this pull request as draft
October 12, 2026 13:54
qroll
force-pushed
the
carousel/format-file-size
branch
from
October 13, 2026 02:22
5cffd49 to
c283757
Compare
qroll
marked this pull request as ready for review
October 13, 2026 04:34
ghazwan-gt
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
Checklist
Added/updated E2E testsvisual display covered inFullscreenImageCarousel-Carousel-with-file-data--mount.png, logic covered by unit tests