Skip to content

Support numeric fileSize in FullscreenImageCarousel - #1500

Merged
qroll merged 3 commits into
masterfrom
carousel/format-file-size
Oct 14, 2026
Merged

qroll merged 3 commits into
masterfrom
carousel/format-file-size

Conversation

@qroll

@qroll qroll commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Small QoL change, noticed that consumer had to reimplement the file size formatting logic in their application
  • Reuses the existing display formatter as with FileDownload

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests visual display covered in FullscreenImageCarousel-Carousel-with-file-data--mount.png, logic covered by unit tests

@qroll
qroll requested review from ghazwan-gt and ziggyzet October 5, 2026 08:31
@qroll qroll added the type: enhancement New feature or request label Oct 5, 2026
@qroll
qroll marked this pull request as ready for review October 6, 2026 01:49
ghazwan-gt
ghazwan-gt previously approved these changes Oct 6, 2026
Comment thread src/fullscreen-image-carousel/fullscreen-image-carousel.tsx Outdated
ziggyzet
ziggyzet previously approved these changes Oct 6, 2026
@qroll
qroll marked this pull request as draft October 12, 2026 13:54
@qroll
qroll dismissed stale reviews from ziggyzet and ghazwan-gt via c283757 October 13, 2026 02:22
@qroll
qroll force-pushed the carousel/format-file-size branch from 5cffd49 to c283757 Compare October 13, 2026 02:22
@qroll
qroll marked this pull request as ready for review October 13, 2026 04:34
@qroll
qroll requested review from ghazwan-gt and ziggyzet October 13, 2026 09:18
@qroll qroll added this to the v4.0.0-alpha.15 milestone Oct 14, 2026
@qroll
qroll merged commit f102180 into master Oct 14, 2026
12 checks passed
@qroll
qroll deleted the carousel/format-file-size branch October 14, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants