Repository navigation
[MOL-21511] Track images by id instead of index in image-upload - #765
Open
tientranngoc-alt wants to merge 2 commits into
Open
tientranngoc-alt wants to merge 2 commits into
tientranngoc-alt wants to merge 2 commits into
Conversation
weili-govtech
requested changes
Oct 13, 2026
| ...image, | ||
| ...(i === activeFileIndex ? { status: EImageStatus.TO_DELETE } : {}), | ||
| })) | ||
| ); |
Contributor
There was a problem hiding this comment.
switch to use id as well
Contributor
There was a problem hiding this comment.
now that we are tracking by id, we need to ensure the prefilled images have unique / no missing ids. use generateRandomId() if they are not unique
Contributor
There was a problem hiding this comment.
can we have tests to guard the issue mentioned? this can happen to upload and image processing in the main upload component and the image review
Author
|
resolved comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
Link to MOL-21511
Description of changes:
image-uploadtracked images by array index. Async steps (compression, file-type check, drawing save) captured the index up front, so if the list changed mid-flight (image removed, added, or rejected), results were written to the wrong image, which makes the processing image frozen / causes something went wrongupdatedImages[index]Checklist