Skip to content

fix: re-raise on test results CSV save failure #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgutzen merged 2 commits into from
Sep 9, 2026
Merged

fix: re-raise on test results CSV save failure #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70c2073
fix: re-raise on test results CSV save failure
rgutzen Sep 9, 2026
b366f12
Merge branch 'main' into fix/test-model-swallowed-csv-write-error
rgutzen Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dynvision/runtime/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ def save_results(self, model: pl.LightningModule, precision: int = 16) -> None:
del results_df
except Exception as e:
logger.error(f"Failed to save test results: {e}")
# Don't silently swallow the error - a partial/corrupt or missing
# test_outputs.csv must fail the job so Snakemake reruns it,
# instead of being picked up as valid input by downstream
# processing steps (mirrors the response-saving error handling below).
raise

# Save model responses (tensors)
try:
Expand Down
Loading