Repository navigation
Configure Pullfrog to run on Fireworks GLM 5.3 - #118
Closed
elviskahoro wants to merge 21 commits into
Closed
elviskahoro wants to merge 21 commits into
elviskahoro wants to merge 21 commits into
Conversation
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
…ed, toBase62) (#5) Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
Fixes copy buttons in chart_util_wrapper and file_codeblock being absolutely positioned without a positioned ancestor, which caused them to anchor to the page root instead of the codeblock. Matches the pattern already used in demo_wrapper. Closes AI-342.
Collapsible panels snap open and closed because the height state selectors have no transition. Match Accordion timing so both interactions animate consistently.
* chore: remove dead menu.py constants and type aliases * Regenerate menu.md after dead-code removal --------- Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
* chore(tools): add gtm-linear and issue-fetch CLI gtm-linear is a Python SDK with no executable, so scripts/linear_cli.py wraps LinearWorkflow as read-only commands (viewer/teams/issues/issue/search) for fetching Linear issues. Auth resolves LINEAR_API_KEY from env or gitignored .env.local. * refactor(tools): port Linear CLI to Typer Type-hint-driven commands, enum state choices, rich --help, typer.echo/secho output. Typer added as a dev dependency. * fix(tools): harden Linear CLI after review - Disable Typer pretty exceptions (locals in tracebacks could expose the API key) - One _fail() error style for all failure paths - Bound --limit to 1-100 via option validation instead of silent clamping - Add CliRunner tests covering state enum, exit codes, auth failure, and LinearAPIError mapping * test(tools): tighten Linear CLI tests after review Assert main() prints the API error to stderr, cover ValidationError handling with from_env patched, document the verified settings sources on the missing-key test, use result.output directly (click 8.2+ interleaves stderr), note the --limit validation behavior in the CLI docstring. * test(tools): finish Linear CLI test polish after review Clear every LINEAR_* env var in the missing-key smoke test, drop the version-pinned comment, add a case proving unrelated from_env exceptions are not misreported. * test(tools): match LINEAR_ env vars case-insensitively pydantic-settings resolves env names case-insensitively; also assert the original exception message survives and document why ValueError guards a ValidationError regression.
…es (#23) Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
The Pullfrog workflow failed with "no API key found" — no provider credentials were configured in GitHub Actions secrets. Route Pullfrog runs to Fireworks GLM 5.3 (the same model roborev uses for reviews in gtm-sdk, accounts/fireworks/models/glm-5p3) via BYOK: - Pin the agent model with a raw models.dev specifier (fireworks-ai/accounts/fireworks/models/glm-5p3) on the pullfrog action's `model` input. - Map FIREWORKS_API_KEY from GitHub Actions secrets into the run env. FIREWORKS_API_KEY has been added as a repo secret. The Pullfrog console model must be set to "Custom (set in workflow)" so the stored console pick does not override the workflow's model input.
Contributor
Author
|
Wrong repo — this was meant for the fork. Apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Pullfrog workflow (run 37134011304) failed with "no API key found" — the repo had zero GitHub Actions secrets configured, and the workflow's
env:block mapped none that existed.Fix
Route Pullfrog runs to Fireworks GLM 5.3 via BYOK — the same model roborev uses for reviews in gtm-sdk (
.roborev.toml:fireworks/accounts/fireworks/models/glm-5p3):modelinput with a raw models.dev specifier:fireworks-ai/accounts/fireworks/models/glm-5p3(per Pullfrog custom providers docs — any models.dev provider activates the moment its API key is in the run env).FIREWORKS_API_KEYfrom GitHub Actions secrets into the runenv:block.FIREWORKS_API_KEYhas been added as a repo secret (verified authenticating againstapi.fireworks.ai).Required console step (manual)
In the Pullfrog console, set the repo model to Custom (set in workflow) — a model stored in the console overrides the workflow's
modelinput, so this must be set for the workflow pin to take effect. Billing Model access should be BYOK.