chore: backport of PR #4160#4161
Open
wucke13 wants to merge 1 commit into
Open
Conversation
Contributor
|
@wucke13 the Fix in void STOP_SPINDLE_TURNING(int spindle, int wait_for_atspeed) {} |
wucke13
force-pushed
the
dev/backport-#4160-to-2.9.8
branch
from
35cd262 to
65f09e9
Compare
wucke13
force-pushed
the
dev/backport-#4160-to-2.9.8
branch
from
65f09e9 to
16c0e4c
Compare
grandixximo
reviewed
Jun 15, 2026
| M3, or stop after M5) before the probe starts. */ | ||
| if (emcmotStatus->atspeed_next_feed) { | ||
| issue_atspeed = 1; | ||
| emcmotStatus->atspeed_next_feed = 0; |
Contributor
There was a problem hiding this comment.
you have one tab too many on these, code-base rules tab=8spaces
Collaborator
|
I think this is too close to changing existing machine behaviour (admittedly for the better) for me to be comfortable merging it this close to the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a clipped down version of
203abbf and 344395e.
@grandixximo please verify carefully, I just blindly removed things from the aforementioned commit until when compilation ran through without errors.