Repository navigation
chore: migrate tooth.json to lip.toml format 4 - #33
Merged
Merged
Conversation
The default variant gets a server entry and a client entry; the variant "client" is kept as an alias with the same client entry, because LeviLauncher and existing installs use github.com/LiteLDev/LeviOptimize#client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
tooth.json(format 3) withlip.tomlof format 4 (lip v0.40.0). Sameid, sameversion(0.18.0), same assets, same placement and same LeviLamina ranges.Variant mapping
""(server build)""github.com/LiteLDev/LeviLamina26.60.*LeviOptimize-server-windows-x64.zipclient""github.com/LiteLDev/LeviLamina#client26.60.*LeviOptimize-client-windows-x64.zipclientclient(alias)github.com/LiteLDev/LeviLamina#client26.60.*LeviOptimize-client-windows-x64.zipBoth zips keep
LeviOptimize/->mods/LeviOptimize/(placementsdir ->placedirectory form).Why
clientis keptLeviLauncher v1.1.0-beta.6 installs catalog mods as
<id>#clientfirst, and updates installed packages with the recorded identity (github.com/LiteLDev/LeviOptimize#client) with no fallback. lip treatsXandX#clientas different identities, so removingclientwould break updates of existing installs. The alias holds the same client entry as"".Intended change: with tooth.json the default variant installed the server build on any side; now
lip install github.com/LiteLDev/LeviOptimizeon a client workspace installs the client build.#clientis client-only now (it was never meaningful on a server).Other changes
info.tags:optimization(recommended tag id); dropped the prefixedplatform:levilamina/type:mod. Emptyavatar_urlreplaced withinfo.logopointing atdocs/logo.png.tooth.json, so no packaging change is needed. Following review, theupdate-release-notesjob ofrelease.ymlnow fails when theversioninlip.tomldiffers from the release tag without its leadingv(the version still has to be bumped by hand before tagging, as with tooth.json). The READMElip installcommands stay valid.Verification
check.ts): parses, both variants listed,""with (server, win-x64) and (client, win-x64),clientwith (client, win-x64).lip install -n <repo>(full resolution incl. LeviLamina, bds, bedrock-runtime-data...) OK;lip install --no-dependencies --ignore-scripts <repo>OK; installed tree identical togithub.com/LiteLDev/LeviOptimize@0.18.0(old tooth.json); upgrade old -> new in place OK.<repo>#clienton the server side is rejected (no server entry), as intended.-n install <repo>and-n install <repo>#client(full resolution incl.LeviLamina#client) OK;-nodeps -ignore-scriptsinstalls of both OK;#clienttree identical togithub.com/LiteLDev/LeviOptimize#client@0.18.0;""on client now equals the client build (old one installed the server build: intended). Upgrade path#client@0.18.0(released) -> local#clientreplaces in place without conflict; the same for"".