Skip to content

fix(ci): pin Windows tray configuration script to v6.2 - #208

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/pin-windows-tray-script-v6.2
Oct 17, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/pin-windows-tray-script-v6.2

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Windows screenshot preparation fails with HTTP 404 because upstream removed Enable-AllTrayIcons.ps1 from its default branch. Pin the download to the immutable v6.2 commit, preserving the existing script invocation and screenshot setup behavior.

This fixes the failure seen in the Sunshine Windows job.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Reproduced HTTP 404 from the original main URL; the pinned URL returns HTTP 200.
  • Confirmed the downloaded script is identical to v6.2 and the file immediately before upstream removal (Git blob c7e3c79adc291fc7185a276e65548e86ce0d9644).
  • Strict yamllint passed with the shared organization configuration.
  • PowerShell parsing passed for both the composite action's embedded script and the downloaded script; the existing invocation parameters are present.
  • git diff --check passed.

No C++ regression test was added because this change only pins an external CI download; the HTTP checks directly reproduce the failure and validate the replacement. Hosted Windows screenshot tests have not been run for this change.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.98%. Comparing base (6f5903b) to head (7a7c7f6).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files           5        5           
  Lines         547      547           
  Branches      212      212           
=======================================
  Hits          350      350           
  Misses        129      129           
  Partials       68       68           
Flag Coverage Δ
Linux-qt5 61.61% <ø> (ø)
Linux-qt6 61.13% <ø> (ø)
Windows-qt6 57.62% <ø> (ø)
macOS-qt6 56.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5903b...7a7c7f6. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-10-17 02:08:28 UTC
Source Run CI Run #860
Commit 7a7c7f69cae3806cb7747679e2cc22ce27076d94

Screenshot Comparison

PR #208 screenshots vs screenshots baseline.

Matrix: Linux-qt5

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Linux-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Windows-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: macOS-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

@ReenigneArcher
ReenigneArcher merged commit 4b494d5 into master Oct 17, 2026
18 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/pin-windows-tray-script-v6.2 branch October 17, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant