Skip to content

ci: fix macOS action shell variable naming - #213

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-sonar-shell-variable-names
Oct 30, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-sonar-shell-variable-names

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Rename the local dbPath and sqlQuery variables to db_path and sql_query in both macOS TCC database helpers, including their SQLite command arguments. This addresses all four open githubactions:S7684 findings in Sonar project LizardByte_tray while preserving the commands and database paths.

Screenshot

Issues Fixed or Closed

Sonar findings: AaGM7uUuEhlCTg74GiYn, AaGM7uUuEhlCTg74GiYo, AaGM7uUuEhlCTg74GiYp, and AaGM7uUuEhlCTg74GiYq.

Roadmap Issues

Testing

  • git diff --check --ignore-submodules=all: passed.
  • Parsed the composite action with PyYAML and ran yamllint with LizardByte/.github's current .yamllint.yml: passed.
  • Extracted the action's run block and checked it with bash -n under MSYS2 UCRT64: passed.

No unit tests were added because this only renames local shell variables. macOS TCC database execution was not run on the Windows host.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.91%. Comparing base (184ff51) to head (83b0210).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files           5        5           
  Lines         546      546           
  Branches      212      212           
=======================================
  Hits          349      349           
  Misses        129      129           
  Partials       68       68           
Flag Coverage Δ
Linux-qt5 61.52% <ø> (ø)
Linux-qt6 61.04% <ø> (ø)
Windows-qt6 57.62% <ø> (ø)
macOS-qt6 56.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184ff51...83b0210. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Last Updated 2026-10-30 14:46:44 UTC
Source Run CI Run #871
Commit 83b02101fd81c32548dc90f4f70a57ad966a03ed

Screenshot Comparison

PR #213 screenshots vs screenshots baseline.

Matrix: Linux-qt5

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Linux-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: Windows-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

Matrix: macOS-qt6

Image Baseline PR
tray_icon_ico.png
tray_icon_initial.png
tray_icon_png.png
tray_icon_svg.png
tray_icon_themed.png
tray_icon_update_ico.png
tray_icon_update_png.png
tray_icon_update_svg.png
tray_icon_update_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_ico_icon.png
tray_notification_png_icon.png
tray_notification_svg_icon.png
tray_notification_themed_icon.png
tray_tooltip_hover.png

@ReenigneArcher
ReenigneArcher merged commit f7a2830 into master Oct 30, 2026
18 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-sonar-shell-variable-names branch October 30, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant