Repository navigation
feat(macos): add opt-in template icons for the menu bar - #219
Merged
ReenigneArcher merged 1 commit intoNov 17, 2026
Merged
Conversation
Open
7 of 18 tasks
|
ReenigneArcher
approved these changes
Nov 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 63.91% 64.33% +0.41%
==========================================
Files 5 5
Lines 546 558 +12
Branches 212 216 +4
==========================================
+ Hits 349 359 +10
- Misses 129 136 +7
+ Partials 68 63 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #219 screenshots vs Matrix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











































Description
Add
tray_init_with_options()andTRAY_OPTION_TEMPLATE_ICONso applications can request native template rendering for file-backed macOS menu bar icons. The option applies at initialization and when the tray icon changes.tray_init()uses the default options, and notification icons use the regular image lookup.This provides the opt-in discussed in #218 and supports SunshineStream/Sunshine#6107.
Screenshot
The Sunshine prototype captures show the same template rendering on a light menu bar and a dark menu bar.
Issues Fixed or Closed
Roadmap Issues
Testing
trayandtest_traywith macOS SDK 27.2 and Qt 6.12.0.test_tray --gtest_filter='TrayQtCoverageTest.*:TrayQtPlatformTest.*'passed all 18 tests. The new cases exercise default rendering and the explicit option at initialization and after an icon update.Type of Change
Checklist
AI Usage
See our AI usage policy.