Skip to content

fix(order): make escrow creation idempotent - #208

Merged
Heazzy500 merged 2 commits into
Local-Settle:mainfrom
Adesokan-2:fix/issue-68-review
Oct 18, 2026
Merged

Heazzy500 merged 2 commits into
Local-Settle:mainfrom
Adesokan-2:fix/issue-68-review

Conversation

@Adesokan-2

Copy link
Copy Markdown
Contributor

Summary

  • Reserve an order creation idempotency key before escrow deployment and bind it to a hash of the submitted request.
  • Reuse a saved deployment and stable order ID on retries, so persistence failures do not deploy duplicate escrows.
  • Add a buyer/seller scoped creation-status endpoint and regression coverage for post-deployment database failures and concurrent retries.

Closes #68

Checks

  • git diff --check passed.
  • Jest tests were not run because dependencies are not installed in this checkout.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Adesokan-2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Adesokan-2

Copy link
Copy Markdown
Contributor Author

@Heazzy500 The idempotent order creation and recovery path for #68 is ready for review. Please take a look and merge when it is ready.

@Heazzy500
Heazzy500 merged commit b3219e9 into Local-Settle:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make order creation idempotent across escrow deployment retries

2 participants