Repository navigation
feat(dashboard): View Plan detail modals for locks and goals - #29
Merged
Mackenzie-OO7 merged 4 commits intoJul 20, 2026
Merged
Conversation
Adds the "View Plan" link to every lock and goal row, opening a read-only breakdown from the mock. - LockPlanModal: principal, term, APY, unlock date, projected yield, and the maturity total (amount + projected_yield). No performance-fee row — the contract charges none. - GoalPlanModal: goal, target, saved so far, deadline, frequency, per-deposit amount, and the withdraw action. Per the design, the goal row now shows Top Up + View Plan, and the destructive withdraw lives inside View Plan (which hands off to the existing payout/confirm modal). Withdrawing early still forfeits 1%, so that button stays red.
Collaborator
|
the 'top up' option should not be available for goals that have been met (either by the user reaching the target amount or the goal deadline has reached). now, it is available for every goal, whether it is done or still in progress. for finished goals, they should only have the "withdraw" option |
Per review (Lokt-In#29): topping up a goal that's already met makes no sense. A goal is finished when its deadline has passed or the target is fully funded (targetStatus 'matured'); in that state the row now offers Withdraw rather than Top Up. It reads 'Withdraw early' (red) when the target was reached before the deadline, since the contract still forfeits 1% then, and 'Withdraw Now' (cyan) once the deadline has passed. In-progress goals keep Top Up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the "View Plan" link to every lock and goal row, opening a read-only breakdown from the mock.