Repository navigation
feat(contracts): add loktin-common crate for storage TTL and ID counters - #45
Open
Peolite001 wants to merge 1 commit into
Open
Peolite001 wants to merge 1 commit into
Peolite001 wants to merge 1 commit into
Conversation
|
@Peolite001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #38
This PR addresses the issue of duplicated TTL constants and inconsistent ID counter behaviors across the contracts by introducing a new
loktin-commoncrate.Changes Made
crates/loktin-common.extend_ttl_instanceandextend_ttl_persistenthelpers using the existing ledger constants (DAY_IN_LEDGERS * 30andDAY_IN_LEDGERS * 365).next_idhelper that guarantees IDs start at1and monotonically increase. Added tests verifying this behavior.spend_save,target_savings,plans,mock_pool, andlocked_in), substituting them with the shared constants imported from the new crate.Acceptance Criteria Met
crates/loktin-commonbuilds as a workspace member.Notes
Adopting the newly added helpers inside each contract's entry points is kept out of scope for this PR, as outlined in the issue requirements.