Add isCharging to uploader device status#2
Open
bjorkert wants to merge 1 commit into
Open
Conversation
Expose an optional isCharging flag on UploaderStatus and include it in the Nightscout device status payload so consumers can show whether the uploading device is on power.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
isChargingflag toUploaderStatusand includes it in the Nightscoutdevicestatusuploaderpayload when present.This lets consumers of the device status (e.g. LoopFollow) show whether the uploading device is currently on power. The field is optional and defaults to
nil, so all existing call sites and payloads are unchanged unless a caller supplies it.The key name
isChargingmatches the field already produced by Trio and consumed by LoopFollow.See also: LoopKit/NightscoutService#26