Bind the market-maker health server on IPv4 - #81
Merged
Merged
Conversation
The load balancer checks the task IPv4 address. listen(port) on the current node image binds IPv6 only, so those checks time out and ECS rolls the task back. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0.listen(port)on the current Node image binds IPv6 only, and the load balancer health check to the task IPv4 times out.v1.4.0was rolled back tov1.3.0for this reason. Devv1.0.180-devstayed up after one task was replaced for the same timeout.Test plan
devand confirmsvc-col-mar-futures-mm-devstays on the new image with a healthy targetmainand confirmsvc-col-mar-futures-mm-lmnstays on the new imageMade with Cursor