Skip to content

Scale kill experience for lower-level targets - #293

Merged
moshehbenavraham merged 3 commits into
masterfrom
branch/kill-xp-falloff
Nov 4, 2026
Merged

moshehbenavraham merged 3 commits into
masterfrom
branch/kill-xp-falloff

Conversation

@moshehbenavraham

@moshehbenavraham moshehbenavraham commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Behavior

  • Pay 25% of the normal capped kill XP at a five-level gap, then halve for each additional level, rounding down with a 1 XP floor for positive awards.
  • Use the credited player's level for solo kills and the rounded-down average of in-room non-pet group members for group kills.
  • Keep the threshold configurable through the existing exp_level_difference setting, with a default of five. Penalized kills use their reduced payout for account XP calculations.

Review and validation

  • Traced combat credit, party eligibility, PvP and character caps, Happy Hour, account XP, and configuration load/save.
  • Widened the gap arithmetic before subtracting legacy mob levels. The production-linked regression covers the boundary, halving, both cap stages, group average, the floor, and an extreme legacy level.
  • make -j12 test passed with 2,091 CuTests. make install and the commit and push hooks passed.
  • The Experience help matches the flat file and the development database. SQLFluff parsed the companion SQL, and a MariaDB fixture verified that it updates the intended row, matches the flat help, and can be applied twice safely.

Rollout

The existing exp_level_difference value remains in effect when explicitly set. The default applies when the setting is absent. Database-first help installations can apply sql/components/help_kill_experience_falloff.sql when publishing the help change. A rollback restores the prior reward code and Experience help text.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T09:27:12.895474Z c129496 New commits
🔒 Security Review ✅ Completed 2026-11-04T09:28:44.338125Z c129496 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@moshehbenavraham
moshehbenavraham merged commit 85fed29 into master Nov 4, 2026
65 checks passed
@moshehbenavraham
moshehbenavraham deleted the branch/kill-xp-falloff branch November 4, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant