Skip to content

fix: use certifi for SSL certificates on macOS #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luna1xiao merged 2 commits into from
Jul 8, 2026
Merged

fix: use certifi for SSL certificates on macOS #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db32e1
fix: use certifi for SSL certificates on macOS
Jul 8, 2026
0c0591d
fix: sort imports and remove unused urlopen
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions backend/feed_engine/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@
from dataclasses import dataclass
from urllib.error import HTTPError, URLError
from urllib.parse import urlsplit
from urllib.request import Request, urlopen
from urllib.request import HTTPSHandler, Request, build_opener

import certifi

from feed_engine.errors import FeedEngineError

Expand Down Expand Up @@ -178,10 +180,16 @@ def _fetch_feed_sync(

request = Request(url, headers=headers)

if url.startswith("https://"):
ssl_context = ssl.create_default_context(cafile=certifi.where())
opener = build_opener(HTTPSHandler(context=ssl_context))
else:
opener = build_opener()

print("[FETCH START]", url)

try:
with urlopen(request, timeout=timeout_seconds) as response:
with opener.open(request, timeout=timeout_seconds) as response:
print("[FETCH OK]", response.status)

return FetchResponse(
Expand Down
1 change: 1 addition & 0 deletions backend/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ dependencies = [
"bleach>=6.2",
"lxml>=5.3",
"markdownify>=1.1",
"certifi>=2024",
]

[dependency-groups]
Expand Down
2 changes: 2 additions & 0 deletions backend/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading