Repository navigation
fix: collect certifi data files in PyInstaller build - #38
Merged
Merged
Conversation
PyInstaller auto-detects Python imports but does not automatically include data files like certifi's cacert.pem. Without this file, the bundled sidecar crashes at startup on HTTPS requests because ssl.create_default_context(cafile=certifi.where()) resolves to a path that does not exist inside the PyInstaller bundle. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyInstaller auto-detects Python imports but does not automatically include data files like certifi's cacert.pem. Without this file, the bundled sidecar crashes at startup on HTTPS requests because ssl.create_default_context(cafile=certifi.where()) resolves to a path that does not exist inside the PyInstaller bundle.
Summary
Module
backend/feed_enginebackend/dbbackend/content_cleanerbackend/agent_summarybackend/agent_translationbackend/llm_providersbackend/app(tech lead)packages/uipackages/shared-types(tech lead)packages/ipc-client(tech lead)apps/desktopChecklist
uv run ruff checkanduv run pytestpass locally (if backend)pnpm typecheckpasses locally (if frontend)pnpm gen:typesand committedpackages/shared-types/src/generated.tsdocs/ipc-contract.md.agent-traces/Coding Agent Trace
Notes for Reviewers