Skip to content

fix: strip URL whitespace and bundle SQL schema files - #39

Merged
Luna1xiao merged 1 commit into
mainfrom
fix/ssl-certificate-verification
Jul 8, 2026
Merged

Luna1xiao merged 1 commit into
mainfrom
fix/ssl-certificate-verification

Conversation

@Luna1xiao

Copy link
Copy Markdown
Owner
  • fetcher.py: strip whitespace from URL netloc/path/query to prevent InvalidURL crash when user accidentally includes spaces in the URL
  • build_sidecar.py: add --add-data for db/schema/*.sql so PyInstaller includes migration files; without them init_db() silently does nothing and the app fails with 'no such table: feeds' on first launch

Summary

Module

  • backend/feed_engine
  • backend/db
  • backend/content_cleaner
  • backend/agent_summary
  • backend/agent_translation
  • backend/llm_providers
  • backend/app (tech lead)
  • packages/ui
  • packages/shared-types (tech lead)
  • packages/ipc-client (tech lead)
  • apps/desktop
  • docs / CI / governance

Checklist

  • Tests added or updated
  • uv run ruff check and uv run pytest pass locally (if backend)
  • pnpm typecheck passes locally (if frontend)
  • Pydantic model changed → ran pnpm gen:types and committed packages/shared-types/src/generated.ts
  • New endpoint → updated docs/ipc-contract.md
  • Coding Agent used → committed a trace under .agent-traces/

Coding Agent Trace

Notes for Reviewers

- fetcher.py: strip whitespace from URL netloc/path/query to prevent
  InvalidURL crash when user accidentally includes spaces in the URL
- build_sidecar.py: add --add-data for db/schema/*.sql so PyInstaller
  includes migration files; without them init_db() silently does nothing
  and the app fails with 'no such table: feeds' on first launch

Co-Authored-By: Claude <noreply@anthropic.com>
@Luna1xiao
Luna1xiao merged commit 280e7ef into main Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant