Repository navigation
Make the required Test check report on every PR - #4
Merged
Merged
Conversation
The branch ruleset requires a status check named Test, but nothing emitted one: the workflow's only checks were the matrix jobs (protobuf 5.29.5, 6.31.1, ...), and the pull_request trigger was path-filtered, so a PR touching only config (e.g. renovate.json) ran no workflow at all. Either way the required check never reported and the PR hung. Add an aggregate job named Test that runs on every PR and passes only when the protobuf matrix passes, and drop the pull_request path filter so it always reports. The matrix stays path-filtered on push. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Review complete. No issues found — approved ✅. This PR touches only the GitHub Actions test workflow, adjusting how CI runs without changing any SDK source code or tests.
Reviewed commit: bcfa770 |
![tenki-reviewer[bot]](https://avatars.githubusercontent.com/in/2900641?s=60&v=4){kind=small}
Keep the required Test check reporting on every PR, but stop running the 4-way protobuf matrix on PRs that touch no test-relevant files. A small changes job diffs the PR against its base with plain git (no third-party changed-files action) and the matrix runs only when src/tests/packaging files changed. The Test gate passes automatically when the matrix is skipped, and otherwise only when it succeeds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mainruleset requires a status check namedTest, but nothing ever produced one, so PRs hang on it indefinitely (first hit on #3, which only touchesrenovate.json). Two causes:protobuf 5.29.5, …) — there was no check namedTest.pull_requesttrigger was path-filtered, so a PR that doesn't touchsrc/**,tests/**, etc. ran no workflow at all and reported nothing.Fix
Testaggregate job runs on every pull request and is the required status check. It reports once and passes only when the matrix passed (or was skipped because nothing test-relevant changed).changesjob gates the expensive 4-way protobuf matrix so it still only runs when test-relevant files change (src/**,tests/**,pyproject.toml,scripts/**,examples/**,uv.lock, the workflow itself). Detection uses plaingit diffagainst the PR base — no third-party changed-files action, to avoid adding a pinned external dependency.Net: the required
Testcheck always reports on every PR, but the matrix only burns runner time when it's actually needed. No new actions or SHAs.After merge, Renovate PRs and config-only PRs get a real
Testcheck instead of hanging. #3 needs a rebase ontomainto pick this up.🤖 Generated with Claude Code