[e-nord]

Changes

• Logs follow --home-dir. The log file target is built from Compat.AppDataHome, and the path is escaped with SimpleLayout.Escape so NLog treats it literally. A relative --home-dir is resolved to a full path.
• Named folder paths. Compat.LogsDir and SettingsManager.PackagesDirectory replace the hand-built paths.
• SettingsManager.EnsureAppDirectories() creates the app's well-known folders: AppDataHome, Logs, Packages, Workflows, Images, ExtensionPacks and the default Models folder.
  • It runs when the library is found, after LoadSettings. The three TryFindLibrary branches now share LoadLibrary().
  • It never creates a Models override or Images/Consolidated.
  • Failures are logged, not thrown.
  • The Workflows and Outputs pages call it instead of creating their own folders.
• Missing folders and files show a notification. IOCommands.OpenFolderBrowserAsync and OpenFileBrowserAsync show a "Folder not found" or "File not found" warning, and they never create anything. The Settings → App Folders shortcuts call EnsureAppDirectories() before opening. CreateLogFolderZip handles a missing Logs folder.

Testing

• New LogFileTargetTests and SettingsManagerDirectoriesTests.
• Manual check on Windows with --home-dir set to a folder named ${shortdate}: logs, the Packages and Logs shortcuts, and recreating deleted folders.
• Unit suite: 629 passed. The one failure (TestGetInstalledExtensionsLiteAsync) also fails on main.

Note: other hardcoded paths that could drift (not changed here)

• LibraryDir/Packages/<name> is built by hand in PackageInstallDetailViewModel, both one-click install view models and BaseGitPackage.DownloadLocation. These could use PackagesDirectory.
• Library-relative LibraryPath values use a literal "Packages" in about 7 places.
• PackageInstallDetailViewModel and IndexUnknownPackages compare LibraryPath as plain strings using the current OS separator. They could miss matches for a library moved between Windows and Unix. This hasn't been reproduced.
• GlobalConfig.ModelsDir is set before settings load, so it ignores a ModelDirectoryOverride.

🤖 Generated with Claude Code

[mohnjiles]

Two path-handling edge cases on the current head. The NLog layout case was reproduced on Windows with the pinned NLog 5.3.2; the Unix backslash case is based on static path analysis.

[ionite34]

Really nice PR, thanks! The --home-dir log fix with escaping plus tests is exactly right, and folding the three TryFindLibrary branches into LoadLibrary() is a good cleanup 🐺

One design ask before we approve: could LoadLibrary() skip calling EnsureAppDirectories(), so TryFindLibrary only finds and loads the library?

The fixes don't depend on that startup call. The places that open folders already handle it themselves:

• OpenDirectoryShortcut calls EnsureAppDirectories() right before opening.
• Workflows and Outputs call it on load.
• IOCommands shows the not-found warning.

Those use-site calls also cover a folder deleted after startup, which the startup call can't. Without it there's no side effect hidden inside a method named Try/Find. Logs, AppData and Models already get created elsewhere: NLog, SetLibraryPath, SetupSharedModelFolders.

SettingsManagerDirectoriesTests would then call EnsureAppDirectories() directly instead of going through TryFindLibrary.

Happy to push that change on top if you'd prefer, just say so!

[e-nord]

Valid point. Thought it might be good to enforce certain directories existing as an invariant at startup but probably better to keep the side-effects to a minimum if its too strict or not in the right spot for that and its getting smoothed over on access anyway. I made the corresponding changes, if anything else needs a correction or tweak go right ahead.

[ionite34]

Thanks, approving :3