Repository navigation
Conversation
Move the TYPE field layout and field tables, the Channel Access Number, and the META type definitions (Text, GNSS, Extended Callsign Data) into the common LSF section. Add a table summarizing TYPE field usage per mode, and replace the Packet Mode TYPE layout with a definition table in which Encryption Type is None and Encryption Subtype selects the META type, ratifying current practice of sending META in Packet Mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Not bad :-) Would that make the Spec 2.1.0? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Packet Mode LSF TYPE currently defines only the Packet/Stream bit and the CAN, and marks everything else Reserved. When no encryption is used, Stream Mode reuses the Encryption Subtype bits as the META type. Existing implementations already send META in Packet Mode and set those bits the same way. This PR changes the spec to match, and puts the shared definitions in one place.
Changes
0x11).Compatibility
No bits change meaning for existing Stream Mode transmissions. The reference packet encoder (
M17_Implementations/SP5WWP/m17-packet/m17-packet-encode.c) sets TYPE toM17_TYPE_PACKET | M17_TYPE_CAN(can)and zeroes META. Under this change that is META type Text Data with Control Byte0x00, which already means "no text", so its output stays valid.Notes for reviewers
🤖 Generated with Claude Code