fix check warnings - #39
Open
manuelpelloni wants to merge 2 commits into
Open
Conversation
Replace the monolithic enum_derive.rs (658 lines) with a module layout: - mod.rs: shared parsing, macros, and input struct - backend.rs: common token emission (gated on postgres|mysql) - postgres.rs: PostgreSQL-specific code generation - mysql.rs: MySQL-specific code generation Also add dead_code suppression annotations on the shared path so compilation is clean when no backend feature is enabled.
Add RUSTFLAGS=-D warnings to the cargo-hack step so the feature power-set check fails on any warning, not just hard errors. Also sort imports in date_part.rs alphabetically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactor:
benzina-derive/src/enum_derive/Split the monolithicenum_derive.rs(658 lines) into a module layout:mod.rs— shared parsing, macros, and input structbackend.rs— common token emission (gated onpostgres|mysql)postgres.rs/mysql.rs— backend-specific code generationdead_codesuppression on the shared path so compilation is clean when no backend feature is enabledCI
RUSTFLAGS=-D warningsto the cargo-hack feature power-set step so the check fails on any