🛡️ Sentinel: [HIGH] Use cryptographically secure random number generator in New-GTPassword

[MARCO-K]

🚨 Severity: HIGH
💡 Vulnerability: New-GTPassword used Get-Random which is not cryptographically secure to generate random characters for passwords.
🎯 Impact: Attackers could potentially predict the output of Get-Random and compromise generated passwords.
🔧 Fix: Replaced Get-Random with [System.Security.Cryptography.RandomNumberGenerator]::Create() and securely generated random bytes to shuffle and select characters. Used bitwise AND to avoid integer overflow from Int32.MinValue.
✅ Verification: Verify that passwords generated by New-GTPassword use strong randomness and meet complexity requirements.

---

PR created automatically by Jules for task 470596087676312878 started by @MARCO-K

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[Copilot]

Copilot review overview

🟡 Changes recommended

The new selection/shuffle logic still introduces avoidable randomness bias (modulo + sort-by-random) and RNG disposal is not exception-safe, which undermines the security goal of the change.

Review effort: Lite
Findings: 1

Open (1)

• RNG disposal is skipped when exceptions occur · New

What changed in this PR

This PR hardens New-GTPassword by replacing Get-Random with System.Security.Cryptography.RandomNumberGenerator to ensure generated passwords use cryptographically strong randomness, aligning with GraphTools’ security-focused incident response tooling.

Changes:

• Replaced Get-Random-based character selection with a CSPRNG-driven selection helper.
• Updated password shuffling to use CSPRNG-derived randomness instead of Get-Random.
• Added a Sentinel learning note documenting the original weakness and the safer pattern.

File	Description
internal/​functions/​New-GTPassword.ps1	Switches password generation from Get-Random to a cryptographic RNG and updates selection/shuffle logic.
.jules/​sentinel.md	Documents the vulnerability and recommended prevention pattern for future changes.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[MARCO-K]

Closed in favor of #93.

[google-labs-jules]

Closed in favor of #93.

Understood. Acknowledging that this work is closed in favor of #93 and stopping work on this PR.