Repository navigation
Use guarded parking for Helidon async delays - #1540
Merged
Merged
Conversation
tomas-langer
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
October 9, 2026 10:17
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Owner
|
Yea, the purpose is to use an async delay |
Owner
|
/benchmark -f helidon-tuned --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
Thread.sleepin bothhelidon-productionandhelidon-tunedasync delay handlers with a small, deadline-guardedLockSupport.parkNanosloop. On JDK 27, virtual-thread sleep restores a parking permit that can add work to the following socket wait.The "simple"
Thread.sleepI used before for delaying work was not the best choice. As I assume this benchmark tries to show how the framework handles work that takes a specified amount of time, it is OK to replace it with a different implementation (i.e. we should not be checking that Thread.sleep is fast, but that Helidon framework handles tasks that take some time correctly).