Repository navigation
feat: add SSRF sink and source modeling (closes #1177) - #1216
Open
bamiebot-maker wants to merge 2 commits into
Open
bamiebot-maker wants to merge 2 commits into
bamiebot-maker wants to merge 2 commits into
Conversation
|
@bamiebot-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@bamiebot-maker kindly resolve this. Thank you. |
|
Hey @bamiebot-maker! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Server-Side Request Forgery (SSRF - CWE-918) sink and source modeling across the engine analyzer and scanner worker boundary:
src/security/ssrf.ts):validateUrlForSsrf: Validates scheme (http:,https:), resolves DNS, rejects loopback (127.0.0.0/8), metadata (169.254.0.0/16,metadata.google.internal), private IPv4/IPv6 ranges, and DNS rebinding attacks.preventSsrf: Safe agent wrapper for HTTP/HTTPS requests.libs/engine/analyzers/ssrf/):ssrf-001: Detects unvalidated HTTP requests (fetch,axios,http.get,requests.get,urllib) using request-derived targets without safe validation.ssrf-002: Detects weak or bypassable validation patterns (startsWith("http://"), unparsed substringindexOf/includes).ssrf-003: Detects cloud metadata (169.254.169.254,metadata.google.internal) and loopback address access.ssrf-004: Detects disabled TLS verification (rejectUnauthorized: false,verify=False).apps/api/src/scanner/ssrf-scan.job.ts):organizationId,repositoryId,analysisJobId), safe analyzer runner with timeouts, and idempotent persistence viaFindingsService.libs/engine/analyzers/ssrf/ssrf-analyzer.spec.ts&lexer.spec.ts.apps/api/src/scanner/ssrf-scan.job.spec.ts.tests/fixtures/ssrf/ssrf.repositories.spec.ts.src/security/ssrf.spec.ts.docs/SSRF_ANALYSIS.md.Closes