Fix Periodic Neighborhood Checking

[danieljvickers]

Description

@conraddelgado reported a bug with periodic boundaries and the IB code on multiple ranks. The cause was ultimately that the periodic bounds checking was failing to catch an edge case where you loop back and lap the entire domain. This adds a 4 line fix that resolves the issue.

Type of change (delete unused ones)

• Bug fix

Testing

I tested with the file that was provided for debugging and observed correct behavior.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.50%. Comparing base (b4be438) to head (4018cb9).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/simulation/m_start_up.fpp	0.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   60.51%   60.50%   -0.02%     
==========================================
  Files          83       83              
  Lines       19905    19909       +4     
  Branches     2950     2951       +1     
==========================================
  Hits        12046    12046              
- Misses       5866     5869       +3     
- Partials     1993     1994       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.