fix: truncate long matched strings in findrefs output - #32
Open
xaoLiu1222 wants to merge 4 commits into
Open
xaoLiu1222 wants to merge 4 commits into
xaoLiu1222 wants to merge 4 commits into
Conversation
enhance gui xref ability by androguard token type
String matches against regex constants (e.g. searching 'frida' hits the 'blackfriday' TLD inside androidx WEB_URL patterns) printed multi-KB regex literals verbatim, flooding the console. Truncate matched string names at 200 chars with an ellipsis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
findrefs stringprints matched string constants verbatim. When the query is a short substring that occurs inside a large regex constant, the whole multi-KB regex floods the console.Repro:
fridamatches theblackfridayTLD inside the androidx WEB_URL pattern constants, printing the entire 2000+ char regex asmatched=(...).Fix
Truncate matched string names at 200 chars with an ellipsis in
_format_matched_name(asc_client/asc_handler.py).Verification
findrefs string fridaoutput now ends with...