Upgrade trunk - #494
Upgrade trunk#494github-actions[bot] wants to merge 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis automated Trunk upgrade updates the repository’s Trunk plugin bundle and nine enabled linter pins in .trunk/trunk.yaml, with no other configuration or source changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".trunk/trunk.yaml" line_range="18" />
<code_context>
enabled:
- gitleaks@8.30.1
- - ty@0.0.28
+ - ty@0.0.74
- pre-commit-hooks@5.0.0
- - trivy@0.69.3
</code_context>
<issue_to_address>
**nitpick:** The Trunk-managed Ruff and ty versions are upgraded, but `uv.lock` still installs ruff 0.15.9 and ty 0.0.28 from the project development dependencies. Developers running these tools through `uv` therefore receive different lint and type-check results from CI.
**Triggers:** When local checks are run through the project's frozen uv environment.
**Suggested fix:** Update the development dependency constraints and regenerate `uv.lock`, or document and enforce Trunk as the sole source for these checks.
</issue_to_address>Sourcery assessment
Approved.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| enabled: | ||
| - gitleaks@8.30.1 | ||
| - ty@0.0.28 | ||
| - ty@0.0.74 |
There was a problem hiding this comment.
nitpick: The Trunk-managed Ruff and ty versions are upgraded, but uv.lock still installs ruff 0.15.9 and ty 0.0.28 from the project development dependencies. Developers running these tools through uv therefore receive different lint and type-check results from CI.
Triggers: When local checks are run through the project's frozen uv environment.
Suggested fix: Update the development dependency constraints and regenerate uv.lock, or document and enforce Trunk as the sole source for these checks.
01cbb8b to
2ec2c3e
Compare
2ec2c3e to
270a70f
Compare
Sourcery withdrew this approval because it has stopped reviewing this pull request.
|
Sourcery has withdrawn its approval of this pull request. It auto-reviews a pull request 5 times, and this push is past that limit, so the approval no longer reflects code Sourcery has read. Comment |
f9d7938 to
b173d4d
Compare
6474e73 to
d7b3b8c
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
547d1d4 to
c39a8fb
Compare
2420953 to
388260a
Compare
388260a to
451dc96
Compare
9 linters were upgraded:
1 plugin was upgraded:
This PR was generated by the Trunk Action. For more info, see our docs or reach out on Slack.
Summary by Sourcery
Enhancements: