Conversation
jazairi
marked this pull request as draft
August 6, 2026 21:14
Why these changes are being introduced: The codebase has several skipped tests, some of which have been skipped for years. We should reevaluate whether these tests still need to be skipped, or if they're even still necessary. Relevant ticket(s): - [ETD-701](https://mitlibraries.atlassian.net/browse/ETD-701) How this addresses that need: - Fixes admin advisor tests related to processor authorization. The underlying issue was that the Ability model did not provide the necessary permissions for the processor role to perform the specified tasks. - Implements Preservation Submission Job test confirming behavior when a 400 error is returned using a stubbed response. - Removes thesis integration test asserting that the thesis form fails validation without files. This validation does not exists, nor should it, as files are added separately in the transfer workflow. - Does *not* alter a test that is skipped because it is slow to run. Because this skip is performance-related and provides an optional override, it makes sense to leave it in place. Side effects of this change: - The Ability model as a whole may require an overhaul. The processor role is not currently in use, and it may not be needed. - A remaining skipped test fails only in GitHub Actions. That will be handled in a separate commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing