Added generalized multiple outputs - #510
Open
seiyatsukamoto wants to merge 1 commit into
Open
seiyatsukamoto wants to merge 1 commit into
seiyatsukamoto wants to merge 1 commit into
Conversation
Contributor
|
I'll give this a look tomorrow. Could you explain the motivation for these changes? |
Author
|
It's for #474. |
Contributor
|
I think we can simplify the ledger changes quite a bit by subclassing class MergerTimeEventSet(EventSet):
merger_time: np.ndarray = parameter()We'll have to generalize the There's a couple of bugs I've noticed in the base branch as well that we should get fixed. Here's what I suggest:
|
Contributor
|
Just merged #511. Give the subclassing approach a try and rebase on top of it. |
seiyatsukamoto
force-pushed
the
regress_merger_time
branch
from
September 2, 2026 14:00
ead0887 to
68833a3
Compare
seiyatsukamoto
force-pushed
the
regress_merger_time
branch
2 times, most recently
from
October 5, 2026 20:58
0a353c9 to
8c70256
Compare
seiyatsukamoto
force-pushed
the
regress_merger_time
branch
from
October 5, 2026 21:08
8c70256 to
bf155ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the export and infer to map multiple outputs.
Changed Ledger to accept dictionaries.
Changed EventSet to take in extra_params.
Added median pool for regression outputs.
Changes shouldn't require changes for single output configs.
Changes were checked with timedomain, merger time regression, and multitask branches.