You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding bns compatibility to buoy, the changes proposed here are backward-compatible. For now, we have two Aframe models, so I think it makes sense to add this compatibility until we unify them.
We can simplify quite a bit here by using sub_configs=True like we do for AMPLFI here. That way, we just need to add an optional augmentor parameter to AframeConfig that will get instantiated by the parameters in the config file. It'll get rid of the extra arguments and the __post_init__.
Also, the augmentations shouldn't live in this repo; they should be imported from Aframe for now, and ideally ml4gw in the future.
I'll follow the AMPLFI implementation and make augmentor a parameter for AframeConfig. I added augmentations.py here because, currently, buoy doesn't have an Aframe dependency. And if I add Aframe dependency, it won't work here because augmentations.py is in the bns-o3-mdc branch and not main. Once we sync those changes with main, I can add Aframe dependency here and remove augmentations.py. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding bns compatibility to
buoy, the changes proposed here are backward-compatible. For now, we have twoAframemodels, so I think it makes sense to add this compatibility until we unify them.Checklist
uv.lockis up to date (uv lock)