Skip to content

add bns model compatibility to buoy - #154

Merged
bhgupta20 merged 2 commits into
ML4GW:augmentor-featurefrom
bhgupta20:bns-compatibility
Sep 30, 2026
Merged

bhgupta20 merged 2 commits into
ML4GW:augmentor-featurefrom
bhgupta20:bns-compatibility

Conversation

@bhgupta20

@bhgupta20 bhgupta20 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adding bns compatibility to buoy, the changes proposed here are backward-compatible. For now, we have two Aframe models, so I think it makes sense to add this compatibility until we unify them.

Checklist

  • Tests added or updated
  • Documentation updated
  • uv.lock is up to date (uv lock)

@bhgupta20
bhgupta20 requested a review from wbenoit26 September 17, 2026 03:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/buoy/utils/augmentation.py 0.00% 48 Missing ⚠️
src/buoy/models/aframe.py 0.00% 18 Missing ⚠️

📢 Thoughts on this report? Let us know!

@wbenoit26

Copy link
Copy Markdown
Contributor

We can simplify quite a bit here by using sub_configs=True like we do for AMPLFI here. That way, we just need to add an optional augmentor parameter to AframeConfig that will get instantiated by the parameters in the config file. It'll get rid of the extra arguments and the __post_init__.

Also, the augmentations shouldn't live in this repo; they should be imported from Aframe for now, and ideally ml4gw in the future.

@bhgupta20

Copy link
Copy Markdown
Contributor Author

I'll follow the AMPLFI implementation and make augmentor a parameter for AframeConfig. I added augmentations.py here because, currently, buoy doesn't have an Aframe dependency. And if I add Aframe dependency, it won't work here because augmentations.py is in the bns-o3-mdc branch and not main. Once we sync those changes with main, I can add Aframe dependency here and remove augmentations.py. What do you think?

@wbenoit26

Copy link
Copy Markdown
Contributor

Yeah, I'm fine with that.

@bhgupta20
bhgupta20 changed the base branch from main to augmentor-feature September 30, 2026 14:10
@bhgupta20
bhgupta20 merged commit 36d5ae2 into ML4GW:augmentor-feature Sep 30, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants