Repository navigation
fix(dfns): mark iper as an index - #397
Merged
Merged
Conversation
IPER is 1-based in the file and 0-based in memory, like every other field marked index = true, but the DFNs didn't say so, so consumers had to recognize it by name. Set index on the period block's header field in the migration, on the same basis as fill_forward: v1 has no tag for it, and period is the only repeating block whose header is a 1-based position. solutiongroup's group_num stays unmarked: it's a label that happens to be a number, not a position into anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPERis 1-based in the file and 0-based in Python , mark it as anindex