Repository navigation
fix(dfns): consistent stress_period_data naming - #399
Merged
Merged
Conversation
A fill-forward block's single list was named per package in v1 (perioddata, lakeperioddata, reachperioddata, mwtperioddata, ...), and OC's synthesized list was named output. Rename them all to stress_period_data in a final dev2 pass, so the name follows from structure rather than a per-package table. Period blocks with several fields (the grid packages' named arrays) and blocks that don't fill forward (TDIS's and ATS's perioddata) keep their names. Input files are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #398, rename every fill-forward stress period data list field to
stress_period_data. We already made these names consistent in flopy4 with some hardcoding, which this makes unnecessary. Period blocks with multiple fields (e.g. grid-array packages) and period blocks that don't fill forward (e.g. TDIS and ATS) are unchanged.