Skip to content

fix(license): say a license expires rather than renews - #1805

Merged
CREDO23 merged 1 commit into
MODSetter:devfrom
CREDO23:license-expires-wording
Sep 17, 2026
Merged

CREDO23 merged 1 commit into
MODSetter:devfrom
CREDO23:license-expires-wording

Conversation

@CREDO23

@CREDO23 CREDO23 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

The licence panel in Settings labelled the expiry date "Renews". Nothing
auto-renews: a licence file carries a fixed expiry date, so the label was
wrong for a trial and misleading for individual and team.

"Expires" is accurate for every plan, which keeps this a single label
rather than a branch on plan. "Ended" stays for the expired state,
where it already read correctly.

Noticed while testing the trial flow end to end against a self-hosted
Keygen CE instance: the imported trial licence showed "Renews Oct 17,
2026".

The test that asserted the old copy is updated in the same commit.
pnpm test passes (7/7 in license-settings.test.tsx).

High-level PR Summary

This PR fixes a misleading label in the license settings panel by changing "Renews" to "Expires" for active licenses. Since license files carry a fixed expiry date and nothing auto-renews, the previous label was inaccurate for trial licenses and misleading for individual and team plans. The corresponding test assertion is updated to match the new copy.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_local/frontend/src/features/license/license-settings.tsx
2 surfsense_local/frontend/src/features/license/license-settings.test.tsx

Need help? Join our Discord

Nothing auto-renews: a licence file carries a fixed expiry date, so
"Renews" was wrong for a trial and misleading for individual and team.
"Expires" is accurate for every plan, which keeps this a single label
rather than a branch on plan.
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cd59daef-6cdc-4988-8625-16c2e6e061bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CREDO23
CREDO23 merged commit d349b60 into MODSetter:dev Sep 17, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant