fix(license): say a license expires rather than renews - #1805
Conversation
Nothing auto-renews: a licence file carries a fixed expiry date, so "Renews" was wrong for a trial and misleading for individual and team. "Expires" is accurate for every plan, which keeps this a single label rather than a branch on plan.
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The licence panel in Settings labelled the expiry date "Renews". Nothing
auto-renews: a licence file carries a fixed expiry date, so the label was
wrong for a trial and misleading for individual and team.
"Expires" is accurate for every plan, which keeps this a single label
rather than a branch on
plan. "Ended" stays for the expired state,where it already read correctly.
Noticed while testing the trial flow end to end against a self-hosted
Keygen CE instance: the imported trial licence showed "Renews Oct 17,
2026".
The test that asserted the old copy is updated in the same commit.
pnpm testpasses (7/7 inlicense-settings.test.tsx).High-level PR Summary
This PR fixes a misleading label in the license settings panel by changing "Renews" to "Expires" for active licenses. Since license files carry a fixed expiry date and nothing auto-renews, the previous label was inaccurate for trial licenses and misleading for individual and team plans. The corresponding test assertion is updated to match the new copy.
⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_local/frontend/src/features/license/license-settings.tsxsurfsense_local/frontend/src/features/license/license-settings.test.tsx