[MV-GH]

Seems to work in initial basic tests.

its deployed https://central.sonatype.com/artifact/it.vercruysse.lemmyapi/lemmy-api-jvm

Also fixes: #67

[dessalines]

Nice, thx. We'll try to get the version stuff figured out quickly. Unfortunately I gotta go back to work on lemmy-ui again as a lot of issues just popped up there.

[dessalines]

Another thing I'm noticing working through jerboa, the CommentActions aren't matching.

lemmy 1.0 uses CommentActions.vote_is_upvote: Boolean? , but in this PR its val like_score: Int = 0

[MV-GH]

Eh didnt really like the true|null|false, so kept the previous behaviour to reduce the refactoring burden. But I dont rlly mind it. But I would prob make into an enum (Upvote/Downvote/NoVote)

[dessalines]

An enum would be fine too, although IMO its best to use as minimal transforms from the original API as possible. Up to you.

[dessalines]

Another minor issue that means this might need to be regenerated: community title is now optional.

[dessalines]

Another related to votes: VoteView has pub is_upvote: bool , but in the API its still a numeric score

[dessalines]

Sweet, thx.

[dessalines]

Nice thx, I'll start adding the vote changes in my 1.0 dev branch soon.

[MV-GH]

I released 0.6.0-beta.3, it doesn't contain any v1 changes but I have refactored the public API, see the README how it looks now. It also includes the Result<> changes. No more unexpected errors.

You can leave it for me, if you cant figure it out. You can stay on that version for now.

[dessalines]

Sweet, I'm still working on jerboa obvi, so I'll let you know in other places if I have any other API related issues.

[MV-GH]

Sure, I have also begun with some initial End to End tests with real Lemmy local instance (docker). So ill have confidence that it works before actually having to try it out in Jerboa