Repository navigation
pyamplicol: drop profiling-campaign and report tooling - #344
Merged
Merged
Conversation
Remove the packaged profiling campaign (`pyamplicol profiling-campaign`), the performance-report and FFT-profiling drivers, the developer gates and benchmarks that only fed them, the UMAMI/MadSpace demo, the nix flake, and their tests and docs. Published reports stay linked from upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #301. Removes pyamplicol files that MadGraph7 doesn't need: 259 files, ~230k lines.
Removed
src/pyamplicol/_profiling_campaign/: the LaTeX report template and stored measurement results thatpyamplicol profiling-campaign copycopied into a new campaign directory. The CLI subcommand and the wheel staging step (_stage_packaged_profiling_campaign, which also bundledtools/performance_reportand the legacy oracle aspyamplicol/_performance_report) are removed with it.tools/performance_report/,tools/fft_profiling/,run_fft_profiling_render.sh,docs/performance_reports/, plus the profiling-campaign and FullColor FFT profiling doc pages.tools/developer/scripts. They are either one-off gates and benchmarks that nothing referenced, or they importtools.performance_report, or they post-process the removed FFT study. Thejustfilerecipesnumerical-acceptance,fft-numerical-acceptanceandfft-performance-acceptancego with them. These were opt-in and not part of CI.umami_example/andflake.nix/flake.lock. The UMAMI doc page now links to the upstream example instead.tests/fixtures/numerical_acceptance/.Kept
justfile, because CI runsjust typing,just rust-checkandjust rust-test.legacy_oracle,reference_capture,reference_fixture,legacy_amplicol.py,analytic_oracles.py),prepare_source_runtime.py, and the remaining benchmark helpers..github/scripts/import_pyamplicol.shis unchanged. Adding these paths to its filter would rewrite every imported commit SHA, and upstream is archived.Other edits
_clean_source_revision. That exception depended ontools/performance_report/source_identity.py..gitattributes: dropped the export-ignore and linguist entries for the deleted paths. Also dropped the-export-ignoreexceptions for the legacy oracle, since the wheel no longer bundles it.docs/source/conf.py: dropped theperformance_reportscopy filter.Testing
justnot installed).pytest --collect-only testscollects 4435 tests with only the three known_rusticolerrors, which also occur without this change.tools/**/*.pymodule imports.