Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Standalone
runtime::PolynomialPlan::newparses Symbolica expressions after scalar primitive registration has dropped its temporary package guard. A first calling thread can retain a restricted user permit, causing a second thread to abort even though the pyAmpliCol package key is active. This blocks subsequent counterterm-tree generation in the one-loop preparation workflow.Minimal Fix
Keep
pyamplicol::unlock()alive for the constructor scope. No numerical formula, public API, dependency, or linker-side licence handling changes.Add a two-thread reproducer covering double generic/fast/fast-tensor, double-double generic, and arbitrary-precision generic construction.
Validation
runtime_reductiontests pass, including the existing scalar-master/Laurent-order and sparse-result checks.rustfmt --checkandgit diff --checkpass.cargo test --locked --offline --release -j 4 \ -p rusticol-loop-reduction --test runtime_reductionThe before/after tests were run in the isolated MadNkLO integration based on
loopat36f43250. The reducer runtime, this test file, crate dependencies, and lockfile are unchanged between that base and this PR base. Full virtual generation and independent amplitude comparison remain separate acceptance gates; this PR does not claim they pass.