Tests: compare the missing-dependency error with STREQUALS

[Kheartz]

Test Build has failed on macos-latest for every PR since #246 merged:

code/tests/modules/resource_manager_ut.h:543:23: error: cannot pass object of
non-trivial type 'const std::string' through variadic function; call will abort
at runtime [-Wnon-pod-varargs]

EQUALS(a, b) expands to FAIL(a, b), which passes both operands to
unit__bprintf under %lld. That is fine for the scalars every other call site
uses, but #246 added one comparing two std::strings. MSVC and GCC only warn;
Clang makes it an error, so the macOS leg never gets past framework_ut.cpp.

Switched that one line to the STREQUALS(x.c_str(), "literal") form the rest of
the suite already uses (engine_ut.h, gui_resources_ut.h). No production code
touched, and unit.h is vendored from zpl-c/tester so it is left alone.

This is not caused by #248 — the same two errors appear in #246's own run
(33796008033),
which was merged red. build-test.yml only runs on PRs into develop, so it
went unnoticed on the branch itself.

Verified locally on Windows/MSVC: FrameworkTests builds, all 23 modules pass
(exit 0), including StartAll fails on a missing required dependency. The macOS
leg on this PR is the real check.

[coderabbitai]

Warning

Review limit reached

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0492b35c-cf39-4cfb-97eb-70d214c3b595

📥 Commits

Reviewing files that changed from the base of the PR and between 6e22126 and d5e4031.

📒 Files selected for processing (1)

• code/tests/modules/resource_manager_ut.h

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}