Repository navigation
Enable isort --sort-reexports option - #47
Merged
Merged
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
Owner
Author
|
The linked issue and another one have been resolved, now just waiting for a stable isort release. |
This version includes the --sort-reexports fixes.
MajorTanya
force-pushed
the
add-isort-sort-reexports
branch
from
September 30, 2026 10:24
9d58fd2 to
5c0d8a9
Compare
MajorTanya
marked this pull request as ready for review
September 30, 2026 10:25
Documentation build overview
12 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't currently enable this on the
v1branch because isort does not respect the trailing commas of short__all__exports and I'd quite like to keep those.See PyCQA/isort#2578
Uses the 9.0.0b1 release for some black-related fixes but the option itself has existed for a long time.
Edit: The unkept trailing commas can be see in the pre-commit.ci fixes to this PR in 9d58fd2.