feat: add copy-all button to export full network request details

[Manabu-GT]

Summary

Add a "Copy All" button to the network request detail screen that exports the complete request/response transaction as formatted plain text, suitable for sharing or debugging.

Changes

• New utility function NetworkRequest.toClipboardText() that formats the full network transaction (overview, headers, body, or error) as plain text

  • Mirrors the Overview/Headers/Body sections shown on the detail screen
  • Omits empty sections (headers/body when absent)
  • Automatically formats JSON bodies with indentation
  • Leaves non-JSON bodies unformatted
  • Shows error details instead of response headers/body when a request fails

• UI enhancement to NetworkRequestDetailScreen

  • Added "Copy All" button (CopyAll icon) next to existing copy buttons in the top app bar
  • Reuses existing clipboard copy infrastructure

• String resource added for the new button's content description (debugoverlay_copy_all)

• Comprehensive test coverage with 4 test cases covering:

  • Full request/response with all sections
  • Minimal request with no headers/body
  • Non-JSON body handling
  • Error state formatting

Implementation Details

The formatting function builds a structured text output with:

• Request line (method + URL)
• Status, duration, timestamp, and sizes
• Optional request/response headers and bodies
• Optional error section with title, message, and stack trace
• JSON pretty-printing when applicable

https://claude.ai/code/session_01A5yvCH5EjpW2JdJZ1ggiTY

Summary by CodeRabbit

• New Features

  • Added options to copy a network request URL or all request and response details.
  • Copied details include metadata, headers, bodies, errors, and formatted JSON when applicable.
  • Large request and response bodies are safely truncated with size information.

• Bug Fixes

  • Improved content-type detection regardless of header capitalization.
  • Preserved response details when requests contain errors.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57e94e4c-37d4-44e8-a8f2-cce2ab9fd828

📥 Commits

Reviewing files that changed from the base of the PR and between 7d80fc3 and ce8cd99.

📒 Files selected for processing (3)

• debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/ui/NetworkRequestDetailScreen.kt
• debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/util/NetworkRequestFormatting.kt
• debugoverlay-core/src/test/kotlin/com/ms/square/debugoverlay/internal/util/NetworkRequestFormattingTest.kt

🚧 Files skipped from review as they are similar to previous changes (2)

• debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/util/NetworkRequestFormatting.kt
• debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/ui/NetworkRequestDetailScreen.kt

---

📝 Walkthrough

Walkthrough

The network detail screen now copies either the request URL or complete request data. Clipboard output includes formatted metadata, headers, bodies, and errors. Shared content-type detection supports case-insensitive headers across detail and HTML rendering.

Changes

Network request clipboard export

Layer / File(s)	Summary
Shared formatting utilities debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/util/Headers.kt, debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/util/TimeFormatters.kt, debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/bugreport/HtmlReportBuilder.kt, debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/ui/NetworkRequestDetailScreen.kt	Adds case-insensitive contentType() lookup and reuses it for network body rendering. The clipboard timestamp formatter is package-internal.
Clipboard text formatting and tests debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/util/NetworkRequestFormatting.kt, debugoverlay-core/src/test/kotlin/com/ms/square/debugoverlay/internal/util/NetworkRequestFormattingTest.kt	Formats request and response sections, pretty-prints JSON, preserves errors, omits empty sections, and truncates each body at 64 KiB. Tests cover these cases.
Copy actions in the detail screen debugoverlay-core/src/main/kotlin/com/ms/square/debugoverlay/internal/ui/NetworkRequestDetailScreen.kt, debugoverlay-core/src/main/res/values/strings.xml	Adds separate URL and complete-request toolbar actions with distinct icons and localized labels.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• Manabu-GT/DebugOverlay-Android#93: Modifies the network detail screen and clipboard-related UI behavior.
• Manabu-GT/DebugOverlay-Android#99: Overlaps with shared content-type handling in HtmlReportBuilder.
• Manabu-GT/DebugOverlay-Android#260: Overlaps with network body formatting, content-type detection, and truncation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a Copy All button to export complete network request details.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/debugoverlay-android-256-u2mfom

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[claude]

Claude finished @Manabu-GT's task in 3m 52s —— View job

---

Code Review: Copy-all button for network request details

• Gather context (diff + related source)
• Review formatting utility
• Review UI changes
• Review tests
• Post review (6 inline comments)

---

Clean, well-scoped feature. The toClipboardText() naming follows the existing LogEntry.toClipboardText() precedent (TimeFormatters.kt:32), JSON pretty-printing reuses formatJsonIfPossible, and the contentDescription correctly goes through a string resource per docs/CODING.md. No new secret exposure — the OkHttp interceptor redacts sensitive headers and query params at capture time (DebugOverlayNetworkInterceptor.kt:163, :446), so this exports only what's already on screen.

One correctness bug worth fixing before merge, plus a few smaller items.

Findings

#	Severity	Issue
1	High	Response headers/body dropped for all HTTP 4xx/5xx (inline)
2	Medium	Case-sensitive content-type lookup (inline)
3	Medium	Main-thread formatting on an unbounded clipboard payload (inline)
4	Low	Exported timestamp has no date (inline)
5	Low	Two adjacent app-bar buttons announced "Copy" / "Copy all" (inline)
6	Low	Test gap: no HTTP-error case; self-referential timestamp assertion (inline)

#1 is the one that matters. NetworkRequestFormatting.kt:23-28 treats error != null as "there is no response" — but the interceptor sets error for every response with code >= 400 (DebugOverlayNetworkInterceptor.kt:153) while still capturing headers and body. So copying a 404 or a 500 — the case you'd most want to share — silently omits the response headers and body. Both other renderings of this data show the error and the response sections (NetworkRequestDetailScreen.kt:185+tabs, HtmlReportBuilder.kt:643-659), so the export also contradicts its own "mirrors the detail screen" doc comment. A suggested diff is in the inline comment.

Two related details: for HTTP errors the interceptor stores the response body in NetworkError.stackTrace (:524), so the body does currently leak into the export — but unlabeled, unformatted, and captioned as a stack trace. And HTTP_CLIENT_ERROR_START is duplicated in both the extension and HttpStatusCodes.kt:22.

Smaller notes

• appendHeadersSection/appendBodySection each hand-roll a "\n\n--- $title ---\n" prefix while the header block uses appendLine. A single StringBuilder.appendSection(title: String, body: String) would remove the asymmetry and make the "no trailing newline" behavior obvious rather than incidental.
• The per-section copy buttons (NetworkRequestDetailScreen.kt:350, :371) copy the raw body while Copy All pretty-prints it. Defensible — different intents — but worth a deliberate call.
• The export omits protocol, which the Overview tab doesn't show either, so it's consistent; still, h2 vs http/1.1 is often useful in a shared transcript.

Validation

I could not run ./gradlew :debugoverlay-core:check or spotlessApply — Gradle invocation was denied by the tool permissions in this environment, so tests, detekt, and spotless are unverified by me. Static read of the new code shows nothing over the 120-char line limit and imports in the configured order. Please rely on CI for the check task.
• claude/debugoverlay-android-256-u2mfom

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 034d9ba3dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions