Fix serialization of pinned view plugin dock widgets - #1287
Merged
Conversation
Contributor
|
I don't currently have an easy way to test this out, but I'm happy to have it on master and will test it when I can. Thank you! |
JulianThijssen
approved these changes
Jul 29, 2026
Contributor
Author
Welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes serialization of pinned/auto-hidden view plugin dock widgets.
Changes
dockWidgetsMap()instead of only walking visible dock containers.Rationale
Pinned/auto-hidden widgets can be registered with ADS without being returned by the previous
dockWidgets()traversal. As a result, ManiVault could omit pinned view plugins during workspace serialization or skip restoring their plugin state after ADS layout restoration.