fix xxhash 4 string hashing, skip numpy-2-incompatible pytables tests - #443
Merged
Conversation
--- # Conversation that produced these changes --- ## User prompt "find out the various reasons why https://github.com/MannLabs/alphabase/actions/runs/33447321676/ jobs failed" "fix 1., deactivate the failing test in 2. with a succint comment on the root cause" ## Clarifying round 1 Q: How should the pytables tests in tests/integration/test_pg_readers.py be deactivated? The failure only occurs when pytables is importable but ABI-broken (tables 3.9.2 + numpy 2.0.2 on py3.9); the stable jobs pass. - Skip only when import fails (Recommended) - Unconditional skip <-- chosen Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lucas-diedrich
approved these changes
Sep 1, 2026
lucas-diedrich
left a comment
lucas-diedrich
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this!
| PGCols.DECOY_INDICATOR, | ||
| ] | ||
|
|
||
| @pytest.mark.skip( |
Collaborator
There was a problem hiding this comment.
Skip for python v3.9 but not v3.11?
--- # Conversation that produced these changes --- ## User prompt "skip the test only for python 3.9" "the word" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with the full test suite introduced recently.