Repository navigation
Embed sources and verify committed builds - #11
Merged
Merged
Conversation
Refresh only expected HTML class names to match the installed KaTeX version. Keep test assertions and runtime behavior unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the critical publishing-pipeline and custom-delimiter fixture issues, plus the workflow’s untracked-file gap.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This pull request improves packaging reproducibility, embeds sources in source maps, documents the build workflow, and updates KaTeX 0.18 fixture expectations.
Changes:
- Enables inline source embedding and regenerates
dist/index.js.map. - Adds committed-build verification and workflow documentation.
- Updates KaTeX fixture expectations.
| File | Summary |
|---|---|
tsconfig.json |
Enables embedded sources. |
test/fixtures/math-in-html.txt |
Updates KaTeX output expectations. |
test/fixtures/fence.txt |
Updates KaTeX output expectations. |
test/fixtures/delimiters.txt |
Updates KaTeX output expectations. |
test/fixtures/default.txt |
Updates expectations; custom-delimiter fixture remains outdated. |
test/fixtures/bare.txt |
Updates KaTeX output expectations. |
README.md |
Documents the build and commit workflow. |
dist/index.js.map |
Regenerated source map with embedded sources. |
.github/workflows/npm.yml |
Adds freshness checking, but does not detect untracked artifacts or cover the publishing pipeline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Check tracked and untracked build changes in both CI pipelines, keep embedded source line endings reproducible, and exercise all five custom-delimiter snapshots with their per-case options. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to @andybp85's packaging fix in #7, landed on
mainvia #10. Thanks for tracking down the clean-install issue!Changes
inlineSourcesand regenerate the map; runtime JavaScript is unchanged.npm run verify-distacross GitHub Actions and both build/test paths of the release pipeline. It rejects modified, deleted, staged, and untracked build files.Validation
npm test.npm run compileandnpm run verify-distpass.core.autocrlf=true.git diff --check.