Skip to content

Embed sources and verify committed builds - #11

Merged
cyanzhong merged 3 commits into
mainfrom
follow-up-packaging-build-checks
Sep 21, 2026
Merged

cyanzhong merged 3 commits into
mainfrom
follow-up-packaging-build-checks

Conversation

@cyanzhong

@cyanzhong cyanzhong commented Sep 21, 2026 •

Copy link
Copy Markdown

Follow-up to @andybp85's packaging fix in #7, landed on main via #10. Thanks for tracking down the clean-install issue!

Changes

  • Enable inlineSources and regenerate the map; runtime JavaScript is unchanged.
  • Share npm run verify-dist across GitHub Actions and both build/test paths of the release pipeline. It rejects modified, deleted, staged, and untracked build files.
  • Keep TypeScript source LF-normalized so embedded sources are reproducible across checkouts.
  • Document the build workflow.
  • Refresh expected KaTeX classes and run all five previously unused custom-delimiter fixtures with their own options, retaining existing behavioral tests. Correct the display-fraction snapshot against independently rendered KaTeX output.

Validation

  • All 71 assertions pass with npm test.
  • npm run compile and npm run verify-dist pass.
  • Isolated Git tests verify clean builds pass and modified/deleted/untracked/staged artifacts fail.
  • Source remains byte-identical with core.autocrlf=true.
  • Verified embedded sources, reproducible output, package contents, and git diff --check.
  • Azure release pipeline wiring was inspected; that pipeline was not executed locally.

cyanzhong and others added 2 commits September 21, 2026 10:03
Follow up on #7 and #10 by keeping packaged source maps usable and checking generated output in CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refresh only expected HTML class names to match the installed KaTeX version. Keep test assertions and runtime behavior unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address the critical publishing-pipeline and custom-delimiter fixture issues, plus the workflow’s untracked-file gap.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity

Open (2)
What changed in this PR

This pull request improves packaging reproducibility, embeds sources in source maps, documents the build workflow, and updates KaTeX 0.18 fixture expectations.

Changes:

  • Enables inline source embedding and regenerates dist/index.js.map.
  • Adds committed-build verification and workflow documentation.
  • Updates KaTeX fixture expectations.
File Summary
tsconfig.json Enables embedded sources.
test/​fixtures/​math-in-html.txt Updates KaTeX output expectations.
test/​fixtures/​fence.txt Updates KaTeX output expectations.
test/​fixtures/​delimiters.txt Updates KaTeX output expectations.
test/​fixtures/​default.txt Updates expectations; custom-delimiter fixture remains outdated.
test/​fixtures/​bare.txt Updates KaTeX output expectations.
README.md Documents the build and commit workflow.
dist/​index.js.map Regenerated source map with embedded sources.
.github/​workflows/​npm.yml Adds freshness checking, but does not detect untracked artifacts or cover the publishing pipeline.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/npm.yml Outdated
Comment thread test/fixtures/default.txt
Check tracked and untracked build changes in both CI pipelines, keep embedded source line endings reproducible, and exercise all five custom-delimiter snapshots with their per-case options.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified, and the supplied validation passes.

Review effort: Lite
Findings: None

Resolved since last review (2)

@cyanzhong cyanzhong changed the title Follow up on packaging: embed sources and verify committed builds Embed sources and verify committed builds Sep 21, 2026
@cyanzhong
cyanzhong merged commit 813d6b6 into main Sep 21, 2026
2 checks passed
@cyanzhong
cyanzhong deleted the follow-up-packaging-build-checks branch September 21, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants