Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Staging still permits stylesheet zoom, and actual label measurements need validation with Mermaid in WKWebView.
1 open finding
What changed in this PR
Addresses #205 by rendering Mermaid diagrams outside zoomed preview content to prevent clipped labels.
Changes:
- Adds hidden staging for Mermaid rendering, preserving bindings and handling obsolete results.
- Scopes scroll synchronization to the visible preview.
- Adds zoom, rendering lifecycle, and scroll regression tests.
| File | Description |
|---|---|
| tests/scroll.test.ts | Tests exclusion of hidden diagram copies. |
| tests/mermaidZoom.test.ts | Tests staging, zoom preservation, and cleanup. |
| tests/build.test.ts | Includes the extracted Mermaid module in build checks. |
| src/view.ts | Passes the preview container to post-render handling. |
| src/scroll.ts | Restricts block lookup to the target container. |
| src/render.ts | Delegates Mermaid loading and rendering. |
| src/quicklook/ui.ts | Passes the Quick Look preview container. |
| src/features/mermaid.ts | Adds staged Mermaid rendering outside preview zoom. |
| dist/lite/markedit-preview.js | Updates generated wiring and scroll lookup. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Actual label sizing still needs WKWebView verification because the added tests mock Mermaid rendering.
0 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205.